Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --use_top_level_targets_for_symlinks with aliases #15316

Closed
wants to merge 1 commit into from
Closed

Fix --use_top_level_targets_for_symlinks with aliases #15316

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Apr 22, 2022

Fixes #14602

@keith keith mentioned this pull request Apr 22, 2022
Closed
@sgowroji sgowroji requested a review from gregestren April 22, 2022 06:04
@sgowroji sgowroji added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Apr 22, 2022
gregestren
gregestren reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@gregestren gregestren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good to me: just a few nitty questions.

third_party/googleapis/google/devtools/build/v1/publish_build_event.proto Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java Show resolved Hide resolved
@keith keith force-pushed the ks/fix-use_top_level_targets_for_symlinks-with-aliases branch from fc11632 to aa18b71 Compare April 25, 2022 20:19
@bazel-io bazel-io closed this in cf6c94b Apr 27, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 28, 2022
@ckolli5
Copy link

ckolli5 commented Apr 28, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io mentioned this pull request Apr 28, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 28, 2022
@ckolli5 ckolli5 mentioned this pull request May 10, 2022
Merged
ckolli5 added a commit that referenced this pull request May 10, 2022
@ckolli5 @keith
Fix --use_top_level_targets_for_symlinks with aliases (#15446)
451861e 
Fixes #14602

Closes #15316.

PiperOrigin-RevId: 444970714

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
meteorcloudy pushed a commit that referenced this pull request May 10, 2022
@ckolli5 @keith @meteorcloudy
Fix --use_top_level_targets_for_symlinks with aliases (#15446)
2649c7c 
Fixes #14602

Closes #15316.

PiperOrigin-RevId: 444970714

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregestren gregestren gregestren approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--use_top_level_targets_for_symlinks doesn't apply through alias() targets
7 participants
@keith @brentleyjones @ckolli5 @gregestren @bazel-io @sgowroji @ShreeM01